upgrade stac-auth-proxy to v1.1.1#191
Merged
Merged
Conversation
Member
|
Hey @batpad, I had to update some other values because of the remote changes: developmentseed/stac-auth-proxy@v1.0.3...v1.1.1 It is deployed on the alpha instance: https://montandon-eoapi-3-auth-proxy.ifrc-go.dev.togglecorp.com/stac/ |
Contributor
Author
|
Thanks much for the fixes @thenav56 ! |
|
Looks good to me. Yes, in a separate step we can use stac-auth-proxy packaged with eoapi-k8s. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We need to upgrade stac-auth-proxy to v1.1.1 as it includes a fix for a recent vulnerability in Starlette.
I think we should just be able to bump this version for now and have things work, but would be good to deploy and test.
I was unable to create a working PoC of bypassing authentication for our current setup, but I have been able to get a PoC working locally against unpatched versions of stac-auth-proxy.
@pantierra - I think we should eventually change how we are setting up stac-auth-proxy? I think there's a better way to do it now that it's packaged with eoapi-k8s? But I think we can treat that separately and for now just apply the version bump patch?
cc @emmanuelmathot @thenav56